netdev - Re: [PATCH net 1/1] inet: fix sysctl_local_ports init when namespaces are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140506225145.GA28325@electric-eye.fr.zoreil.com>
Date:	Wed, 7 May 2014 00:51:45 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Stefan de Konink <stefan@...ink.de>,
	Daniel Borkmann <dborkman@...hat.com>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net 1/1] inet: fix sysctl_local_ports init when
 namespaces are used

Cong Wang <cwang@...pensource.com> :
> On Mon, May 5, 2014 at 10:53 PM, Francois Romieu <romieu@...zoreil.com> wrote:
> > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=75221
> >
> 
> Well, $subject sucks, it only fixes !CONFIG_PROC_SYSCTL case actually...

Sure. It says "fix something" though.

> > Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> > Reported-by: Stefan de Konink <stefan@...ink.de>
> > Tested-by: Stefan de Konink <stefan@...ink.de>
> 
> I had some better fixes pending (I already tested them, just waiting to
> submit).

Before ping patch (!CONFIG_PROC_SYSCTL): the ping group range is zero due
to kzalloc and friends.

After ping patch  (!CONFIG_PROC_SYSCTL): the ping group range is disabled
and it can't be set afterwards.

It isn't exactly "still work" but it's a welcome improvement.

Feel free to submit formally so that davem can pick those up.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html