netdev - Re: [PATCH net-next v2 1/2] net: systemport: only update UMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140507.155957.393285971385097449.davem@davemloft.net>
Date:	Wed, 07 May 2014 15:59:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: systemport: only update UMAC_CMD
 if something changed

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon,  5 May 2014 12:20:51 -0700

> +		reg &= ~((CMD_SPEED_MASK << CMD_SPEED_SHIFT) |
> +				CMD_HD_EN | CMD_RX_PAUSE_IGNORE |
> +				CMD_TX_PAUSE_IGNORE);

While you're here use indentation more consistent with the rest of the
networking for this kind of expression.

On the second and third line, indent to the first column after the openning
parenthesis on the first line.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html