netdev - Re: [Patch net-next] net: clean up snmp stats code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140507.160637.784739838834354060.davem@davemloft.net>
Date:	Wed, 07 May 2014 16:06:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, cl@...ux.com, eric.dumazet@...il.com
Subject: Re: [Patch net-next] net: clean up snmp stats code

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon,  5 May 2014 15:55:55 -0700

> commit 8f0ea0fe3a036a47767f9c80e (snmp: reduce percpu needs by 50%)
> reduced snmp array size to 1, so technically it doesn't have to be
> an array any more. What's more, after the following commit:
> 
> 	commit 933393f58fef9963eac61db8093689544e29a600
> 	Date:   Thu Dec 22 11:58:51 2011 -0600
> 
> 	    percpu: Remove irqsafe_cpu_xxx variants
> 	    
> 	    We simply say that regular this_cpu use must be safe regardless of
> 	    preemption and interrupt state.  That has no material change for x86
> 	    and s390 implementations of this_cpu operations.  However, arches that
> 	    do not provide their own implementation for this_cpu operations will
> 	    now get code generated that disables interrupts instead of preemption.
> 
> probably no arch wants to have SNMP_ARRAY_SZ == 2. At least after
> almost 3 years, no one complains.
> 
> So, just convert the array to a single pointer and remove snmp_mib_init()
> and snmp_mib_free() as well.
> 
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

This is a very nice cleanup, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html