netdev - Re: [PATCH net-next] qlcnic: Fix Kconfig dependency on HWMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140507.172348.946895436076177246.davem@davemloft.net>
Date:	Wed, 07 May 2014 17:23:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	harish.patil@...gic.com
Cc:	netdev@...r.kernel.org, shahed.shaikh@...gic.com,
	Dept-HSGLinuxNICDev@...gic.com, arnd@...db.de
Subject: Re: [PATCH net-next] qlcnic: Fix Kconfig dependency on HWMON

From: Harish Patil <harish.patil@...gic.com>
Date: Wed, 7 May 2014 02:06:15 -0400

> Commit 1f0f467b670e "qlcnic: Add hwmon interface to export board
> temperature" introduced a randconfig build error in the case
> when the hwmon framework is built as a module and the qlcnic
> driver itself is built-in:
> 
> drivers/built-in.o: In function `qlcnic_register_hwmon_dev':
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c:1301:
> undefined reference to `hwmon_device_register_with_groups'
> drivers/built-in.o: In function `qlcnic_unregister_hwmon_dev':
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c:1309:
> undefined reference to `hwmon_device_unregister'.
> 
> This changes the Kconfig logic to enforce that the qlcnic hwmon
> support can only be enabled if it is possible to successfully
> build it.
> 
> Signed-off-by: Harish Patil <harish.patil@...gic.com>
> Reported-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks for following up on this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html