netdev - Re: [PATCH net-next v2 1/2] net: systemport: only update UMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGVrzcY14pLoEUC8MPne8LBnQ3WUOyxJf6LLQ=AwpBJNJsx3+A@mail.gmail.com>
Date:	Wed, 7 May 2014 14:38:01 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/2] net: systemport: only update UMAC_CMD if
 something changed

2014-05-07 12:59 GMT-07:00 David Miller <davem@...emloft.net>:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Mon,  5 May 2014 12:20:51 -0700
>
>> +             reg &= ~((CMD_SPEED_MASK << CMD_SPEED_SHIFT) |
>> +                             CMD_HD_EN | CMD_RX_PAUSE_IGNORE |
>> +                             CMD_TX_PAUSE_IGNORE);
>
> While you're here use indentation more consistent with the rest of the
> networking for this kind of expression.
>
> On the second and third line, indent to the first column after the openning
> parenthesis on the first line.

My email client does not render this properly apparently, so I do see
the same problem as you hinted, but the lines do really follow your
recommendation if you take a look at the raw patch in e.g: patchwork.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html