netdev - Re: [PATCH v1] net-sysfs: expose permanent hardware address in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5369C3A1.2070502@gmail.com>
Date:	Tue, 06 May 2014 22:24:49 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Decotigny <decot@...glers.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Weilong Chen <chenweilong@...wei.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Michael Dalton <mwdalton@...gle.com>,
	Al Viro <viro@...IV.linux.org.uk>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v1] net-sysfs: expose permanent hardware address in sysfs

Le 05/05/2014 20:34, David Decotigny a écrit :
> Tested:
>    grep . /sys/class/net/*/*addr*

Please also include the relevant sysfs documentation changes in 
Documentation/ABI/testing/sysfs-class-net.

Thanks!

>
> Signed-off-by: David Decotigny <decot@...glers.com>
> ---
>   net/core/net-sysfs.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index 1cac29e..bf57024 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -127,6 +127,20 @@ static ssize_t address_show(struct device *dev, struct device_attribute *attr,
>   }
>   static DEVICE_ATTR_RO(address);
>
> +static ssize_t perm_addr_show(struct device *dev, struct device_attribute *attr,
> +			      char *buf)
> +{
> +	struct net_device *net = to_net_dev(dev);
> +	ssize_t ret = -EINVAL;
> +
> +	read_lock(&dev_base_lock);
> +	if (dev_isalive(net))
> +		ret = sysfs_format_mac(buf, net->perm_addr, net->addr_len);
> +	read_unlock(&dev_base_lock);
> +	return ret;
> +}
> +static DEVICE_ATTR_RO(perm_addr);
> +
>   static ssize_t broadcast_show(struct device *dev,
>   			      struct device_attribute *attr, char *buf)
>   {
> @@ -391,6 +405,7 @@ static struct attribute *net_class_attrs[] = {
>   	&dev_attr_addr_len.attr,
>   	&dev_attr_link_mode.attr,
>   	&dev_attr_address.attr,
> +	&dev_attr_perm_addr.attr,
>   	&dev_attr_broadcast.attr,
>   	&dev_attr_speed.attr,
>   	&dev_attr_duplex.attr,
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html