netdev - Re: [PATCH net-next 1/3] bonding: remove the unnecessary struct bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140507132642.GP6295@redhat.com>
Date:	Wed, 7 May 2014 15:26:42 +0200
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	fubar@...ibm.com, andy@...yhouse.net, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] bonding: remove the unnecessary struct
 bond_net

On Wed, May 07, 2014 at 11:45:17AM +0800, Ding Tianhong wrote:
>Move the structure bond_net forward, and remove the unnecessary structure declaration.
>
>Cc: Ding Tianhong <dingtianhong@...wei.com>
>Cc: Jay Vosburgh <fubar@...ibm.com>
>Cc: Andy Gospodarek <andy@...yhouse.net>
>Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
>---
> drivers/net/bonding/bonding.h | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
>index b8bdd0a..9f23bf3 100644
>--- a/drivers/net/bonding/bonding.h
>+++ b/drivers/net/bonding/bonding.h
>@@ -487,7 +487,14 @@ static inline bool slave_can_tx(struct slave *slave)
> 		return false;
> }
>
>-struct bond_net;
>+struct bond_net {
>+	struct net *		net;	/* Associated network namespace */

You might as well clean this up to look like "foo *bar;".

>+	struct list_head	dev_list;
>+#ifdef CONFIG_PROC_FS
>+	struct proc_dir_entry *	proc_dir;

Ditto.

>+#endif
>+	struct class_attribute	class_attr_bonding_masters;
>+};
>
> int bond_arp_rcv(const struct sk_buff *skb, struct bonding *bond, struct slave *slave);
> void bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, struct net_device *slave_dev);
>@@ -516,15 +523,6 @@ struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond);
> struct net_device *bond_option_active_slave_get(struct bonding *bond);
> const char *bond_slave_link_status(s8 link);
>
>-struct bond_net {
>-	struct net *		net;	/* Associated network namespace */
>-	struct list_head	dev_list;
>-#ifdef CONFIG_PROC_FS
>-	struct proc_dir_entry *	proc_dir;
>-#endif
>-	struct class_attribute	class_attr_bonding_masters;
>-};
>-
> #ifdef CONFIG_PROC_FS
> void bond_create_proc_entry(struct bonding *bond);
> void bond_remove_proc_entry(struct bonding *bond);
>-- 
>1.8.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html