netdev - Re: [PATCH] cfg80211/mac80211: Fix warning on make xmldocs caused by cfg80211.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALLJCT2Y=0v7m0hSSBTaAQMqeNCfyXQS=S8pEERYev9YuyUqhw@mail.gmail.com>
Date:	Thu, 8 May 2014 00:49:17 +0900
From:	Masanari Iida <standby24x7@...il.com>
To:	Luciano Coelho <luciano.coelho@...el.com>
Cc:	johannes.berg@...el.com, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH] cfg80211/mac80211: Fix warning on make xmldocs caused by cfg80211.h

Hi,
Your patch fixed the symptom.
I have tested it on linux-next as of 7th/May.
Thank you.

Tested-by: Masanari Iida <standby24x7@...il.com>

Regards,
Masanari

On Sat, May 3, 2014 at 3:15 PM, Luciano Coelho <luciano.coelho@...el.com> wrote:
> Hi,
>
> A better way to fix this would be to add "iftype" to the function
> prototype, since we don't usually use nameless arguments:
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 43c674e..f9e7373 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -458,7 +458,7 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy,
>   */
>  int cfg80211_chandef_dfs_required(struct wiphy *wiphy,
>                                   const struct cfg80211_chan_def *chandef,
> -                                 enum nl80211_iftype);
> +                                 enum nl80211_iftype iftype);
>
>  /**
>   * ieee80211_chandef_rate_flags - returns rate flags for a channel
>
> --
> Cheers,
> Luca.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html