netdev - RE: [PATCH v2 2/3] net: davinci_mdio: Convert pr_err() to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B5657A6538887040AD3A81F1008BEC63AD20DC@avmb3.qlogic.org>
Date:	Thu, 8 May 2014 16:50:41 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	George Cherian <george.cherian@...com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>,
	"mugunthanvnm@...com" <mugunthanvnm@...com>,
	"balbi@...com" <balbi@...com>,
	"zonque@...il.com" <zonque@...il.com>,
	"mpa@...gutronix.de" <mpa@...gutronix.de>,
	"tklauser@...tanz.ch" <tklauser@...tanz.ch>
Subject: RE: [PATCH v2 2/3] net: davinci_mdio: Convert pr_err() to dev_err()
 call

> Also, Convert kzalloc to devm_kzalloc.

Looks like you should remove this part of the comment.

>
> Signed-off-by: George Cherian <george.cherian@...com>
> Reviewed-by: Felipe Balbi <balbi@...com>
> ---
>  drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
> b/drivers/net/ethernet/ti/davinci_mdio.c
> index 34e97ec..735dc53 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> @@ -303,7 +303,7 @@ static int davinci_mdio_probe_dt(struct
> mdio_platform_data *data,
>               return -EINVAL;
>
>       if (of_property_read_u32(node, "bus_freq", &prop)) {
> -             pr_err("Missing bus_freq property in the DT.\n");
> +             dev_err(&pdev->dev, "Missing bus_freq property in the DT.\n");
>               return -EINVAL;
>       }
>       data->bus_freq = prop;

________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html