netdev - Re: [PATCH iproute2] tc/netem: fix loss state display and p14 parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140509120749.0150c757@nehalam.linuxnetplumber.net>
Date:	Fri, 9 May 2014 12:07:49 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jay Vosburgh <jay.vosburgh@...onical.com>
Cc:	netdev@...r.kernel.org, netem@...ts.linux-foundation.org
Subject: Re: [PATCH iproute2] tc/netem: fix loss state display and p14
 parsing

On Thu, 08 May 2014 19:02:20 -0700
Jay Vosburgh <jay.vosburgh@...onical.com> wrote:

> 
> 	The display of the entire netem loss state is shown as if it
> were gemodel state, as the loss state information is assigned to the
> wrong pointer.  Correct this by assigning the loss state to the correct
> pointer.
> 
> 	Additionally, attempting to set netem loss state will result in
> random values in the p14 state probability because the option value
> passed to the kernel by tc netem is not parsed or initialized.  Fix this
> by supplying a default value of 0 for p14 and parsing the p14 value if
> one is supplied.
> 
> Signed-off-by: Jay Vosburgh <jay.vosburgh@...onical.com>
> 
> ---
>  tc/q_netem.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html