netdev - Re: [PATCH net-next 1/2] net: Expose header length compution function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140509.162454.1317479460010270185.davem@davemloft.net>
Date:	Fri, 09 May 2014 16:24:54 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	netdev@...r.kernel.org, idos@...lanox.com,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, gregory.v.rose@...el.com,
	alexander.h.duyck@...el.com, john.ronciak@...el.com,
	mitch.a.williams@...el.com, yevgenyp@...lanox.com,
	ogerlitz@...lanox.com
Subject: Re: [PATCH net-next 1/2] net: Expose header length compution
 function

From: Amir Vadai <amirv@...lanox.com>
Date: Thu,  8 May 2014 15:50:33 +0300

> From: Ido Shamay <idos@...lanox.com>
> 
> This commit exposes an header length compution generic function,
> introduced in some of Intel's Etherent drivers (igb and ixgbe),
> to net public namespace under the name __net_get_headlen,
> where it can be used by other vendors and removes code duplication.
> 
> Signed-off-by: Ido Shamay <idos@...lanox.com>
> Signed-off-by: Amir Vadai <amirv@...lanox.com>

First of all, this appears (at least to me) to duplicate a lot of
what the existing flow dissector can do.

For example, you can probably call skb_flow_dissect() and the
filled in flow_keys has much of what you need.  If it doesn't
have everything you need consider extending it.

Even if that won't work out, you must add a detailed comment, with
kernel doc, above the declaration for this new interface in the
header file.

I honestly still have no idea exactly what this function does and
exactly what it's trying to achieve.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html