netdev - Re: [PATCH] checkpatch: Make --strict a default for files in drivers/net and net/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399671852.2912.29.camel@joe-AO725>
Date:	Fri, 09 May 2014 14:44:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kim Phillips <kim.phillips@...escale.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch: Make --strict a default for files in
 drivers/net and net/

On Fri, 2014-05-09 at 16:29 -0500, Kim Phillips wrote:
[]
> > > this isn't easily extensible/scalable to other subsystems, or
> > > say something like "all Freescale drivers."  Having it configurable
> > > in .checkpatch.conf might be a better solution, but I don't believe
> > > networking should be the only subsystem that can take advantage of
> > > the extra checkpatch CHECKs.
> > 
> > staging probably could too.
> 
> why call staging out to be subject to stricter checks than the rest
> of the kernel, when it's code that's _known_ to be non-compliant?

Staging is mostly a "play area sandbox" for people
that want to submit "my first kernel patch" and
GregKH seems to apply style-only patches like that.

> > > Can we enable --strict universally in the Linux kernel, maybe like
> > > so:?
> > 
> > I don't think that's appropriate (yet?).
> 
> why not?  checkpatch CHECKs seem reasonably stable AFAICT.

Several maintainers have their own style or don't
care at all about what indentation is used.

Several maintainers prefer stasis to what they
perceive as changes that are just whitespace noise.

> would an alternative option be to promote CHECKs like parentheses
> alignment to WARN status?

Probably not.

> > Try that with a per-file "wc -l" for checks per LOC
> 
> good point, that reinforces the statement back for networking :) :
> 
> {drivers/}net/ :            0.013 CHECKs per .[hc] file line
> everything else:            0.43  CHECKs per .[hc] file line
> no net, no drivers/staging: 0.38  CHECKs per .[hc] file line

yup. cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html