netdev - Re: [PATCH] neigh: set nud_state to NUD_INCOMPLETE when probing router reachability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 May 2014 23:11:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	duanj.fnst@...fujitsu.com
Cc:	jbenc@...hat.com, hannes@...essinduktion.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] neigh: set nud_state to NUD_INCOMPLETE when probing
 router reachability

From: Duan Jiong <duanj.fnst@...fujitsu.com>
Date: Wed, 7 May 2014 17:33:27 +0800

> In addition, use neigh_max_probes() to simplify function.
 ...
> -	atomic_set(&neigh->probes, NEIGH_VAR(neigh->parms, UCAST_PROBES));
...
> +	atomic_set(&neigh->probes, neigh_max_probes(neigh));

This is not an equivalent transformation, this changes things, in
particular APP_PROBES will be included now.

That's a functional change, not just "to simplify the function."

You'll therefore need to explain in detail why this is a valid
change and why it should be made.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html