netdev - Re: [PATCH 0/7] net: Checksum offload changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140508.234827.771833499800031850.davem@davemloft.net>
Date:	Thu, 08 May 2014 23:48:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/7] net: Checksum offload changes - Part II

From: Tom Herbert <therbert@...gle.com>
Date: Wed, 7 May 2014 16:51:33 -0700 (PDT)

> I am working on overhauling RX checksum offload. Goals of this effort
> are:
> 
> - Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
> - Preserve CHECKSUM_COMPLETE through encapsulation layers
> - Don't do skb_checksum more than once per packet
> - Unify GRO and non-GRO csum verification as much as possible
> - Unify the checksum functions (checksum_init)
> - Simply code
> 
> What is in this second patch set:
> 
> - Call common inet checksum validation functions in ICMP{4,6},
>   GRE{4,6}, and IGMP.
> - In UDP, verify checksum before handing off to encap_rcv.
> - Remove custom UDP checksum validation code in L2TP.
> 
> Please review carefully and test if possible, mucking with basic
> checksum functions is always a little precarious :-)

This looks good to me, applied, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html