lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 May 2014 23:34:17 -0700 From: Xi Wang <xii@...gle.com> To: Jason Wang <jasowang@...hat.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Maxim Krasnyansky <maxk@....qualcomm.com>, Neal Cardwell <ncardwell@...gle.com>, Eric Dumazet <edumazet@...gle.com> Subject: Re: [PATCH] net-tun: restructure tun_do_read for better sleep/wakeup efficiency >>>> + /* Read frames from queue */ >>>> + skb = __skb_recv_datagram(tfile->socket.sk, noblock ? MSG_DONTWAIT : 0, >>>> + &peeked, &off, &err); >>>> + if (skb) { >>> This changes the userspace ABI a little bit. Originally, userspace can >>> see different error codes and do responds, but here it can only see zero. >> >> Thanks for catching this! Seems forwarding the &err parameter of >> __skb_recv_datagram >> should get the most of the error code compatibility back? > > Seems not, -ERESTARTSYS and EIO were missed. -ERESTARTSYS would be returned through sock_intr_errno -> wait_for_more_packets -> __skb_recv_datagram., -EIO would still be missing. -Xi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists