netdev - Re: [PATCH net v3] sfc: fix calling of free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 May 2014 10:25:21 +0100
From:	Shradha Shah <sshah@...arflare.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>, <netdev@...r.kernel.org>
CC:	Zenghui Shi <zshi@...hat.com>, Ben Hutchings <ben@...adent.org.uk>,
	<linux-net-drivers@...arflare.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net v3] sfc: fix calling of free_irq with already free
 vector

On 09/05/14 10:11, Nikolay Aleksandrov wrote:
> If the sfc driver is in legacy interrupt mode (either explicitly by
> using interrupt_mode module param or by falling back to it) it will
> hit a warning at kernel/irq/manage.c because it will try to free an irq
> which wasn't allocated by it in the first place because the MSI(X) irqs are
> zero and it'll try to free them unconditionally. So fix it by checking if
> we're in legacy mode and freeing the appropriate irqs.
>
> CC: Zenghui Shi <zshi@...hat.com>
> CC: Ben Hutchings <ben@...adent.org.uk>
> CC: <linux-net-drivers@...arflare.com>
> CC: Shradha Shah <sshah@...arflare.com>
> CC: David S. Miller <davem@...emloft.net>
>
> Fixes: 1899c111a535 ("sfc: Fix IRQ cleanup in case of a probe failure")
> Reported-by: Zenghui Shi <zshi@...hat.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>

Acked-by: Shradha Shah <sshah@...arflare.com>

> ---
> v3: Use the EFX_INT_MODE_USE_MSI macro instead of direct check
> as suggested by Ben
> v2: Change the fix to check for the interrupt mode and adjust the
> commit message.
>
>  drivers/net/ethernet/sfc/nic.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/nic.c b/drivers/net/ethernet/sfc/nic.c
> index 32d969e857f7..89b83e59e1dc 100644
> --- a/drivers/net/ethernet/sfc/nic.c
> +++ b/drivers/net/ethernet/sfc/nic.c
> @@ -156,13 +156,15 @@ void efx_nic_fini_interrupt(struct efx_nic *efx)
>       efx->net_dev->rx_cpu_rmap = NULL;
>  #endif
>
> -     /* Disable MSI/MSI-X interrupts */
> -     efx_for_each_channel(channel, efx)
> -             free_irq(channel->irq, &efx->msi_context[channel->channel]);
> -
> -     /* Disable legacy interrupt */
> -     if (efx->legacy_irq)
> +     if (EFX_INT_MODE_USE_MSI(efx)) {
> +             /* Disable MSI/MSI-X interrupts */
> +             efx_for_each_channel(channel, efx)
> +                     free_irq(channel->irq,
> +                              &efx->msi_context[channel->channel]);
> +     } else {
> +             /* Disable legacy interrupt */
>               free_irq(efx->legacy_irq, efx);
> +     }
>  }
>
>  /* Register dump */
>
The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html