netdev - Re: [PATCH net-next 1/4] net: cdc_mbim: optionally use VLAN ID 4094 for IP session 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r440oh14.fsf@nemi.mork.no>
Date:	Sun, 11 May 2014 10:28:55 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	<netdev@...r.kernel.org>
Cc:	<linux-usb@...r.kernel.org>,
	Alexey Orishko <alexey.orishko@...il.com>,
	Oliver Neukum <oliver@...kum.org>,
	Greg Suarez <gsuarez@...thmicro.com>
Subject: Re: [PATCH net-next 1/4] net: cdc_mbim: optionally use VLAN ID 4094 for IP session 0

Bjørn Mork <bjorn@...k.no> writes:

> @@ -164,12 +211,24 @@ static struct sk_buff *cdc_mbim_tx_fixup(struct usbnet *dev, struct sk_buff *skb
>  			skb_pull(skb, ETH_HLEN);
>  		}
>  
> +		/* Is IP session <0> tagged too? */
> +		if (!tci && info->flags & FLAG_IPS0_VLAN) {
> +			/* drop all untagged packets */
> +			if (!tci)
> +				goto error;
> +			/* map MBIM_IPS0_VID to IPS<0> */
> +			if (tci == MBIM_IPS0_VID)
> +				tci = 0;
> +		}

This is embarrassing.  I made a mess of this, "tidying" it up while
doing the final rebase before submitting.  And obviously never tested
the final result...

Will fix and submbit a new version.  Sorry for the noise.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html