netdev - Re: [PATCH 8/8] vxlan: Add support for zero UDP6 checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx-0GHNRZ+midMYa4SNv33jmF62Cgv2Y188JqPnx7NH5bg@mail.gmail.com>
Date:	Mon, 12 May 2014 16:35:21 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 8/8] vxlan: Add support for zero UDP6 checksums

On Mon, May 12, 2014 at 2:41 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Mon, May 12, 2014 at 9:59 AM, Tom Herbert <therbert@...gle.com> wrote:
>> @@ -1756,7 +1754,8 @@ int vxlan_xmit_skb(struct vxlan_sock *vs,
>>         uh->source = src_port;
>>
>>         uh->len = htons(skb->len);
>> -       uh->check = 0;
>> +
>> +       udp_set_csum(vs->sock->sk, skb, src, dst, skb->len);
>
> How does this interact with inner checksum offloading? I don't think
> that we have any infrastructure to support computing two checksums on
> a packet yet.

Right, as it stands now we could overwrite the csum offload parameters
for the inner header which would be a problem. I will fix that.

The ability to offload two csums in TX could be quite useful for
encapsulations like vxlan. I don't know if any HW is planning to
support that...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html