netdev - Re: icmp: account for ICMP out errors because of socket limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5370528A.1000806@gmail.com>
Date:	Mon, 12 May 2014 12:48:10 +0800
From:	zhuyj <zyjzyj2000@...il.com>
To:	eric.dumazet@...il.com, "David S. Miller" <davem@...emloft.net>
CC:	"Tao, Yue" <Yue.Tao@...driver.com>, linux-kernel@...r.kernel.org,
	netdev <netdev@...r.kernel.org>, zhuyj <zyjzyj2000@...il.com>
Subject: Re: icmp: account for ICMP out errors because of socket limit

Hi, Eric && David

This patch is similar to the following patch.

commit 1f8438a853667d48055ad38384c63e94b32c6578
Author: Eric Dumazet <eric.dumazet@...il.com>
Date:   Sat Apr 3 15:09:04 2010 -0700

     icmp: Account for ICMP out errors

     When ip_append() fails because of socket limit or memory shortage,
     increment ICMP_MIB_OUTERRORS counter, so that "netstat -s" can report
     these errors.

     LANG=C netstat -s | grep "ICMP messages failed"
         0 ICMP messages failed

     For IPV6, implement ICMP6_MIB_OUTERRORS counter as well.

     # grep Icmp6OutErrors /proc/net/dev_snmp6/*
     /proc/net/dev_snmp6/eth0:Icmp6OutErrors                     0
     /proc/net/dev_snmp6/lo:Icmp6OutErrors                       0

     Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
     Signed-off-by: David S. Miller <davem@...emloft.net>

Best Regards!
Zhu Yanjun

On 05/12/2014 11:19 AM, zhuyj wrote:
> Hi, Eric && David
>
>  ____           ______________
> |    |         |              |
> | PC |<------->| MIPS 32 core |
> |____|         |______________|
>
> When ping from a PC to a board (MIPS 32 core), because of socket limit,
> ping echo will fail. But ICMP_MIB_OUTERRORS counter is not incremented.
> In this case, "netstat -s" can not report these errors.
>
> This patch will fix this problem. Now it is in the attachment. Please 
> check it.
>
> Best Regards!
> Zhu Yanjun

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html