lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 12 May 2014 00:57:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bh74.an@...sung.com
Cc:	netdev@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	ks.giri@...sung.com, vipul.pandya@...sung.com
Subject: Re: [PATCH 0/3] net: sxgbe: Added dma related function and
 non-burst mode support

From: Byungho An <bh74.an@...sung.com>
Date: Fri, 09 May 2014 11:03:43 +0900

> This series added 
> - functions to update rx descriptor tail pointer 
> - non burst mode support
> - fixed dma channel feature.

This description is not sufficient.

I don't understand what non fixed burst mode means, and why
it is so critical to add support for it in 'net' which is
only for bug fixes.

I also do not understand what the "mtl and dma channel" feature is,
what was wrong with it, and what exactly patch #3 is doing to fix it.

Finally, I have no idea why the tail pointer update is necessary
and what problem it is fixing.

You have several things to address in this patch series before I
can apply it.

Furthermore, you have to make it clear what tree you intend these
changes to go into.  'net' is only for bug fixes, and 'net-next'
is for cleanups and new features.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists