netdev - Re: [PATCH] e1000: To filter the negative skb->len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399953861.7973.42.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 12 May 2014 21:04:21 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	xuyongjiande@...il.com
Cc:	linux.nics@...el.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] e1000: To filter the negative skb->len

On Tue, 2014-05-13 at 11:33 +0800, xuyongjiande@...il.com wrote:
> From: Yongjian Xu <xuyongjiande@...il.com>
> 
> skb->len is unsigned int, "skb->len <= 0" should be "(int)(skb->len) <= 0".

Why ?

Did you hit a case skb->len would be 0 or 'negative' ?

This test makes no sense, just remove it.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html