netdev - Re: bonding directly changes underlying device address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+pOBw4M-ZFF2qsqNgGJcKcRRdhWFf4dy1FQ8Ngr-ZqRA@mail.gmail.com>
Date:	Tue, 13 May 2014 20:38:01 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Jay Vosburgh <jay.vosburgh@...onical.com>
Cc:	Jiri Pirko <jiri@...nulli.us>, Or Gerlitz <ogerlitz@...lanox.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Eyal Perry <eyalpe@...lanox.com>,
	netdev <netdev@...r.kernel.org>,
	Noa Osherovich <noaos@...lanox.com>
Subject: Re: bonding directly changes underlying device address

On Tue, May 13, 2014 at 7:30 PM, Jay Vosburgh
<jay.vosburgh@...onical.com> wrote:
>>Tue, May 13, 2014 at 01:06:56PM CEST, ogerlitz@...lanox.com wrote:

[...]

>>>I suspect this can lead to funny (or actually sad) bugs in networking
>>>drivers, can we avoid that?

>         Changing this would also remove support for the tlb mode from
> any device that cannot change their MAC while open.  I don't know how
> many devices that is (it's probably a small number nowadays), but if
> it's not zero then an assessment on losing that support has to be made.

Focusing on the last part of your reply, are you OK with a patch that
branches on whether that device supports ndo_set_mac_address and if
this is the case we will call dev_set_mac_address, else do the current
practice of setting dev_addr directly?

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html