netdev - Re: [PATCH] net: phy: resume phydev when PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53726999.4050103@cogentembedded.com>
Date:	Tue, 13 May 2014 22:51:05 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Zhangfei Gao <zhangfei.gao@...aro.org>,
	sebastian.hesselbarth@...il.com, f.fainelli@...il.com,
	davem@...emloft.net
CC:	netdev@...r.kernel.org, Jiancheng Xue <xuejiancheng@...wei.com>
Subject: Re: [PATCH] net: phy: resume phydev when PHY_RESUMING

Hello.

On 05/13/2014 01:23 PM, Zhangfei Gao wrote:

> Commit be9dad1f9f26604fb suspend phydev when going to HALTED.

    Please also specify that commit's summary line in parens.

> However not to resume phydev when going to RESUMING.
> BMCR_PDOWN remains set "ifconfig eth0 down" -> "ifconfig eth0 up".
> Unless phy_attach_direct is called in open function.

> Fix the issue via phy_resume in PHY_RESUMING

> Signed-off-by: Jiancheng Xue <xuejiancheng@...wei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@...aro.org>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html