netdev - Re: [patch] net, filter: make new test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMEtUuwOY=k8hcpn4CsiNLTHgnxwidZgwXD=UsU-65+LcrmOGQ@mail.gmail.com>
Date:	Tue, 13 May 2014 13:07:41 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch] net, filter: make new test_bpf depend on networking

On Tue, May 13, 2014 at 12:57 PM, David Rientjes <rientjes@...gle.com> wrote:
> CONFIG_TEST_BPF depends on CONFIG_NET, otherwise the build fails:
>
> ERROR: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> ERROR: "kfree_skb" [lib/test_bpf.ko] undefined!
> ERROR: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> ERROR: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> ERROR: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Add the dependency.
>
> Cc: Alexei Starovoitov <ast@...mgrid.com>
> Signed-off-by: David Rientjes <rientjes@...gle.com>

commit 98920ba6911c7 ("net: fix test_bpf build to depend on NET")
is already in net-next.
Sorry about the breakage.

> ---
>  lib/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1639,6 +1639,7 @@ config TEST_USER_COPY
>  config TEST_BPF
>         tristate "Test BPF filter functionality"
>         default n
> +       depends on NET
>         depends on m
>         help
>           This builds the "test_bpf" module that runs various test vectors
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html