netdev - Re: bonding directly changes underlying device address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140513115527.GC2910@minipsycho.orion>
Date:	Tue, 13 May 2014 13:55:27 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Eyal Perry <eyalpe@...lanox.com>,
	netdev <netdev@...r.kernel.org>,
	Noa Osherovich <noaos@...lanox.com>
Subject: Re: bonding directly changes underlying device address

Tue, May 13, 2014 at 01:06:56PM CEST, ogerlitz@...lanox.com wrote:
>Hi Jay, Veaceslav
>
>I see  now that alb_set_slave_mac_addr directly changes the
>underlying device mac address without calling dev_set_mac_address
>when running in TLB mode. Is that on purpose? if yes, can you explain
>why?

I believe that is a bug. dev_addr change should be always done using
dev_set_mac_address.

>
>I suspect this can lead to funny (or actually sad) bugs in networking
>drivers, can we avoid that?
>
>Or.
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html