netdev - RE: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 May 2014 14:57:27 +0000
From:	"Ronciak, John" <john.ronciak@...el.com>
To:	"xuyongjiande@...il.com" <xuyongjiande@...il.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0

> -----Original Message-----
> From: xuyongjiande@...il.com [mailto:xuyongjiande@...il.com]
> Sent: Monday, May 12, 2014 10:07 PM
> To: eric.dumazet@...il.com
> Cc: e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Yongjian Xu
> Subject: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0
> 
> From: Yongjian Xu <xuyongjiande@...il.com>
> 
> There is no case skb->len would be 0 or 'negative'.
> Remove the check.
> 
> Signed-off-by: Yongjian Xu <xuyongjiande@...il.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
> b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 27058df..660971f 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3105,11 +3105,6 @@ static netdev_tx_t e1000_xmit_frame(struct
> sk_buff *skb,
>  	 */
>  	tx_ring = adapter->tx_ring;
> 
> -	if (unlikely(skb->len <= 0)) {
> -		dev_kfree_skb_any(skb);
> -		return NETDEV_TX_OK;
> -	}
> -
>  	/* On PCI/PCI-X HW, if packet size is less than ETH_ZLEN,
>  	 * packets may get corrupted during padding by HW.
>  	 * To WA this issue, pad all small packets manually.
> --
> 1.9.1
What is the exact problem that this is fixing?  Did you have a test case that showed a problem with it?

Cheers,
John


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html