netdev - Re: [PATCH v2] neigh: set nud_state to NUD_INCOMPLETE when probing router reachability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140513.124354.854952996973060630.davem@davemloft.net>
Date:	Tue, 13 May 2014 12:43:54 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	duanj.fnst@...fujitsu.com
Cc:	netdev@...r.kernel.org, jbenc@...hat.com,
	hannes@...essinduktion.org
Subject: Re: [PATCH v2] neigh: set nud_state to NUD_INCOMPLETE when probing
 router reachability

From: Duan Jiong <duanj.fnst@...fujitsu.com>
Date: Fri, 9 May 2014 13:16:48 +0800

> Since commit 7e98056964("ipv6: router reachability probing"), a router falls
> into NUD_FAILED will be probed.
> 
> Now if function rt6_select() selects a router which neighbour state is NUD_FAILED,
> and at the same time function rt6_probe() changes the neighbour state to NUD_PROBE,
> then function dst_neigh_output() can directly send packets, but actually the
> neighbour still is unreachable. If we set nud_state to NUD_INCOMPLETE instead
> NUD_PROBE, packets will not be sent out until the neihbour is reachable.
> 
> In addition, because the route should be probes with a single NS, so we must
> set neigh->probes to neigh_max_probes(), then the neigh timer timeout and function
> neigh_timer_handler() will not send other NS Messages.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html