netdev - RE: [PATCH net-next 0/5] bonding: simple macro cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1724466A@AcuExch.aculab.com>
Date:	Wed, 14 May 2014 13:08:19 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Veaceslav Falico' <vfalico@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...hat.com>
Subject: RE: [PATCH net-next 0/5] bonding: simple macro cleanup

From: Veaceslav Falico
> Hi,
> 
> That's a trivial patchset that tries to unify the macro usage of bonding
> modes. I've split it into two approaches - either BOND_*, which takes
> bonding struct as a param, or MODE_*, which takes the mode itself. Also,
> introduce BOND_MODE(bond) instead of ugly bond->params.mode.

I'm not sure these are improvements....

I thought that netdev (in particular) preferred static inline functions
to #defines - and especially #defines that expand their argument(s)
more than once.

IMHO Simple access functions are just a PITA when reading code since
they cause the reader to go off somewhere and look up the definition.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html