netdev - Re: [PATCH] ax88179_178a: don't send commands to detached device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1405141111420.1432-100000@iolanthe.rowland.org>
Date:	Wed, 14 May 2014 11:12:57 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Emil Goode <emilgoode@...il.com>
cc:	"David S. Miller" <davem@...emloft.net>,
	Freddy Xin <freddy@...x.com.tw>,
	Eric Dumazet <edumazet@...gle.com>,
	David Chang <dchang@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ming Lei <ming.lei@...onical.com>,
	Gerry Demaret <gerry@...ron.be>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	<linux-usb@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ax88179_178a: don't send commands to detached device

On Wed, 14 May 2014, Emil Goode wrote:

> The .stop and .unbind callbacks of struct driver_info are
> called even after a DETACH hot-plug event. In the case of
> the ax88179_178a minidriver we need to make sure we are not
> trying to send commands to a device that has been detached.
> This leads to failure messages like below.
> 
> ax88179_178a 1-1.3:1.0 (unregistered net_device):
> 	Failed to write reg index 0x0001: -19

Most driver don't bother to do this.  A few error messages in the log 
when a device gets unplugged are harmless.  Besides, this won't help 
with errors that occur between the time the device is unplugged and the 
time when the unbind callback runs.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html