netdev - Re: [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514084025.1531d496@nehalam.linuxnetplumber.net>
Date:	Wed, 14 May 2014 08:40:25 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	shemminger@...tta.com, mst@...hat.com, john.r.fastabend@...el.com,
	jhs@...atatu.com
Subject: Re: [PATCH net-next 2/8] bridge: Keep track of ports capable of
 automatic discovery.

On Wed, 14 May 2014 11:09:22 -0400
Vlad Yasevich <vyasevic@...hat.com> wrote:

> +void br_port_flags_change(struct net_bridge_port *p, unsigned long old_flags)
> +{
> +	struct net_bridge *br = p->br;
> +	unsigned long mask = old_flags ^ p->flags;
> +
> +	if (!(mask & BR_AUTO_MASK))
> +		return;
> +
> +	nbp_update_port_count(br);
> +}

Minor nit, why have negative logic here.
Instead use:
	if (mask & BR_AUTO_MASK)
		nbp_update_port_count(br);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html