netdev - Re: [Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix fragmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514180610.31293ff0@zoidberg>
Date:	Wed, 14 May 2014 18:06:10 +0200
From:	Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
To:	Alexander Aring <alex.aring@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix
 fragmentation

On Wed, 14 May 2014 17:56:57 +0200
Alexander Aring <alex.aring@...il.com> wrote:

> > +
> > +	frag = alloc_skb(real_dev->hard_header_len +
> > +			 real_dev->needed_tailroom + size,
> > +			 GFP_ATOMIC);
> 
> Why not keep netdev_alloc_skb for the real_dev?
> 
> But then we need to use dev_kfree_skb.

Because netdev_alloc_skb allocates "for RX", which uses different
allocation flags internally and might do the wrong thing when memory
is tight.

Also, all skb free funtions are essentially the same, where
dev_kfree_skb == kfree_skb by a macro definition, and what remains
differs pretty much only in how it shows up in traces. They all call
__kfree_skb internally.

> 
> - Alex

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html