[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1400084757.19788.12.camel@joe-AO725>
Date: Wed, 14 May 2014 09:25:57 -0700
From: Joe Perches <joe@...ches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc: davem@...emloft.net, Jacob Keller <jacob.e.keller@...el.com>,
netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 02/11] ixgbe: clean up checkpatch warnings about
CODE_INDENT and LEADING_SPACE
On Wed, 2014-05-14 at 01:54 -0700, Jeff Kirsher wrote:
trivial note:
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
[]
> @@ -362,7 +362,7 @@ struct ixgbe_ring_container {
> for (pos = (head).ring; pos != NULL; pos = pos->next)
>
> #define MAX_RX_PACKET_BUFFERS ((adapter->flags & IXGBE_FLAG_DCB_ENABLED) \
> - ? 8 : 1)
> + ? 8 : 1)
My preference would be to use a form that keeps the
actual statement on a single line like:
#define MAX_RX_PACKET_BUFFERS \
(adapter->flags & IXGBE_FLAG_DCB_ENABLED ? 8 : 1)
or if you really like parentheses
#define MAX_RX_PACKET_BUFFERS \
((adapter->flags & IXGBE_FLAG_DCB_ENABLED) ? 8 : 1)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists