netdev - RE: [PATCH net-next v2 2/8] tipc: compensate for double accounting in socket rcv buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A2BAEFC30C8FD34388F02C9B3121859D1C251554@eusaamb103.ericsson.se>
Date:	Wed, 14 May 2014 17:52:50 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	David Miller <davem@...emloft.net>
CC:	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	Erik Hugne <erik.hugne@...csson.com>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>,
	"maloy@...jonn.com" <maloy@...jonn.com>,
	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH net-next v2 2/8] tipc: compensate for double accounting
 in socket rcv buffer



> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of David Miller
> Sent: May-14-14 1:37 PM
> To: Jon Maloy
> Cc: eric.dumazet@...il.com; netdev@...r.kernel.org;
> paul.gortmaker@...driver.com; Erik Hugne; ying.xue@...driver.com;
> maloy@...jonn.com; tipc-discussion@...ts.sourceforge.net
> Subject: Re: [PATCH net-next v2 2/8] tipc: compensate for double accounting
> in socket rcv buffer
> 
> From: Jon Maloy <jon.maloy@...csson.com>
> Date: Wed, 14 May 2014 12:53:45 +0000
> 
> > Because TCP can throw away packet in such situations, and TIPC cannot.
> 
> Just want to state for the record that I consider any transport, even over
> directly connected ethernet, that cannot retransmit at the socket level and
> does not accomodate packet reordering, to be fundamentally flawed.

When I say link level, I am not talking about Ethernet. I am talking about
TIPC' own link layer that handles sequence ordering, retransmission,  
packet bundling (~NAGLE), flow control (not the same as the one we were
discussing) and   above all tight neighbor supervision and failover if one of
several parallel links fail. This can be carried over Ethernet, Infiniband, and
soon to come UDP.  We can detect neighbor loss within 50 ms in small
clusters, and either do failover or report the failure. Or both.

This worked flawlessly when we had 10 MB hubs with extreme loss rates,
and it still works fine. 

> 
> Even if you can absolutely prove that ethernet is %100 drop free and will
> never reorder your frames, some of those things can always happen in the
> system itself since memory is not infinite and your protocol is not the only
> consumer of kernel memory in the system.
> 
> You have to accomodate packet drops, at any level, and recover in some
> reasonable way from this.
> 
> So even with byte based flow control, TIPC I think will still have fundamental
> issues with data handling.

I once presented TIPC for you,  although it is a while ago.  Maybe you don't remember,
or I wasn't clear enough about this. All this is in place, and much more.

Regards
///jon

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the body
> of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html