netdev - Re: [PATCH] net: Use a more standard macro for INET_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400100249.30384.32.camel@joe-AO725>
Date:	Wed, 14 May 2014 13:44:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...hat.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Use a more standard macro for INET_ADDR_COOKIE

On Wed, 2014-05-14 at 16:08 -0400, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Tue, 13 May 2014 20:30:07 -0700
> 
> > Missing a colon on definition use is a bit odd so
> > change the macro for the 32 bit case to declare an
> > __attribute__((unused)) and __deprecated variable.
> > 
> > The __deprecated attribute will cause gcc to emit
> > an error if the variable is actually used.
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> 
> This is fine, applied, thanks Joe.
> 
> Perhaps it would have been nicer to make the macros be initializers,
> so that it still would look like a proper variable declaration at
> the use sites:
> 
> 	const __addrpair var = INET_ADDR_COOKIE(x, y, z);
> 
> or something like that.

Maybe so, but there's no way to add an __attribute__
before the = sign for the 32 bit case like that without
another #define and it would then always require
initialization too.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html