netdev - Re: [net-next 02/11] ixgbe: clean up checkpatch warnings about CODE_INDENT and LEADING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1400100488.4788.3.camel@jekeller-desk1.amr.corp.intel.com>
Date:	Wed, 14 May 2014 20:48:08 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"joe@...ches.com" <joe@...ches.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next 02/11] ixgbe: clean up checkpatch warnings about
 CODE_INDENT and LEADING_SPACE

On Wed, 2014-05-14 at 09:25 -0700, Joe Perches wrote:
> On Wed, 2014-05-14 at 01:54 -0700, Jeff Kirsher wrote:
> 
> trivial note:
> 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> []
> > @@ -362,7 +362,7 @@ struct ixgbe_ring_container {
> >  	for (pos = (head).ring; pos != NULL; pos = pos->next)
> >  
> >  #define MAX_RX_PACKET_BUFFERS ((adapter->flags & IXGBE_FLAG_DCB_ENABLED) \
> > -                              ? 8 : 1)
> > +			      ? 8 : 1)
> 
> My preference would be to use a form that keeps the
> actual statement on a single line like:
> 
> #define MAX_RX_PACKET_BUFFERS					\
> 	(adapter->flags & IXGBE_FLAG_DCB_ENABLED ? 8 : 1)
> 
> or if you really like parentheses
> 
> #define MAX_RX_PACKET_BUFFERS					\
> 	((adapter->flags & IXGBE_FLAG_DCB_ENABLED) ? 8 : 1)
> 
> 
> 

I agree, but this should be fixed in a follow-on patch, as I actually
automatically generated this by fixing leading space characters.

Thanks,
Jake