netdev - Re: [Patch net] loopback: explicitly set pkt_type to PACKET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWSek9=F=WYAzBgE41_C+ep_=V4yOidBm9EYgKDXYB-SA@mail.gmail.com>
Date:	Wed, 14 May 2014 14:24:33 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Cong Wang <xiyou.wangcong@...il.com>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net] loopback: explicitly set pkt_type to PACKET_HOST

On Wed, May 14, 2014 at 11:39 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> From: Cong Wang <cwang@...pensource.com>
>
> In a corner case where I redirect the packets from veth to lo,
> packets are dropped silently when entering IP stack. This is
> due to we have a different MAC addr on veth, so the packets are
> marked as PACKET_OTHERHOST. And after they are redirect to lo,
> this value is kept since lo has the same MAC addr with the packets.
> Loopback should explicitly set it to PACKET_HOST before calling
> eth_type_trans() for this specific case.
>

Note, I am not quite sure about this. There might be some other case
we xmit a packet with !PACKET_HOST via loopback?

PACKET_BROADCAST, PACKET_MULTICAST and PACKET_OTHERHOST
could be fixed up by eth_type_trans().

PACKET_USER and PACKET_KERNEL are only used by netlink.

PACKET_FASTROUTE is unused.

PACKET_OUTGOING seems only used by packet socket and decnet.

PACKET_LOOPBACK is used by multicast but should completely skip loopback
device via dev_loopback_xmit().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html