netdev - Re: [PATCH] net: systemport: Use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002201cf6f34$4d1ecb40$e75c61c0$%han@samsung.com>
Date:	Wed, 14 May 2014 14:21:03 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Florian Fainelli' <f.fainelli@...il.com>
Cc:	"'David S. Miller'" <davem@...emloft.net>,
	'netdev' <netdev@...r.kernel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] net: systemport: Use devm_ioremap_resource()

On Wednesday, May 14, 2014 1:05 PM, Florian Fainelli wrote:
> 2014-05-13 20:15 GMT-07:00 Jingoo Han <jg1.han@...sung.com>:
> > Use devm_ioremap_resource() because devm_request_and_ioremap() is
> > obsoleted by devm_ioremap_resource().
> 
> As of net-next of today, I see nothing that warns when using this
> function that it is obsolete, nor is it commented as such, how about
> it gets annotated with __deprecated so people stop using it even for
> new submissions?

I agree with your suggestion. I will send the patch to mark it as
deprecated. :-)


> 
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thank your Acked-by.

Best regards,
Jingoo Han

> 
> > ---
> >  drivers/net/ethernet/broadcom/bcmsysport.c |    7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
> > index 4dc8d1e..1fa5205 100644
> > --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> > +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> > @@ -1514,10 +1514,9 @@ static int bcm_sysport_probe(struct platform_device *pdev)
> >                 goto err;
> >         }
> >
> > -       priv->base = devm_request_and_ioremap(&pdev->dev, r);
> > -       if (!priv->base) {
> > -               dev_err(&pdev->dev, "register remap failed\n");
> > -               ret = -ENOMEM;
> > +       priv->base = devm_ioremap_resource(&pdev->dev, r);
> > +       if (IS_ERR(priv->base)) {
> > +               ret = PTR_ERR(priv->base);
> >                 goto err;
> >         }
> >
> > --
> > 1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html