lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 14 May 2014 01:55:05 -0400
From:	Sucheta Chakraborty <>
To:	<>
CC:	<>, <>,
	<>, <>,
	<>, <>, <>,
Subject: [RFC v4 0/1]: Add minimum bandwidth support in IP tool.

Today IP tool allows configuring only maximum bandwidth.
Likewise minimum bandwidth can also be configured for a VF. It puts
lower limit on the VF bandwidth. VF is guaranteed to have a bandwidth
of at least this value.

With this change, user can alter minimum bandwidth rate.

This patch series has 1 combined patch that adds required support in kernel
and qlcnic driver changes for minimum bandwidth support.

This change also requires changes in IP tool. I am sending that patch

Changes in v2 per suggestions from Ben Hutchings and Michal Kubecek:

   net patch:
        o Fixed enum index for IFLA_VF_RATE
        o ndo_set_vf_rate replaces ndo_set_vf_tx_rate. Drivers that currently implement
          ndo_set_vf_tx_rate is converted to implement ndo_set_vf_rate instead.
        o If only IFLA_VF_TX_RATE is specified, the core should get the current minimum
          before calling ndo_set_vf_rate.
        o IFLA_VF_RATE should override if both IFLA_VF_RATE and IFLA_VF_TX_RATE are specified.
        o Combined qlcnic patch to add support for minimum bandwidth with net patch

Changes in v3 as per suggestions from Ben Hutchings

    net patch:
        o If user enters only one value out of min_tx_rate or max_tx_rate, the other
          value will be read back in userspace for IFLA_VF_RATE.

        o For IFLA_VF_TX_RATE, min rate will still be read in kernel space to preserve
          (a) between old tool sends "rate" and kernel is new (expects "min" and "max")
          (b) or, when new tool sends only "rate" and kernel is old (expects only "rate")

Change in v4 as per suggestions from Stephen Hemminger:

     No change in net patch. Change in Iproute patch w.r.t display of min_tx_rate and max_tx_rate.

Please comment.


Sucheta Chakraborty (1):
  net: Add support to configure SR-IOV VF minimum and maximum Tx
    rate through ip tool.

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c  |    3 +-
 drivers/net/ethernet/emulex/benet/be_main.c        |   20 +++++---
 drivers/net/ethernet/intel/i40e/i40e_main.c        |    2 +-
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |    6 ++-
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h |    3 +-
 drivers/net/ethernet/intel/igb/igb_main.c          |   20 +++++---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |    2 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c     |   13 +++--
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h     |    3 +-
 drivers/net/ethernet/mellanox/mlx4/cmd.c           |   11 ++--
 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h        |    1 +
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |    2 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov.h  |    2 +-
 .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c   |    1 +
 .../net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c   |   52 ++++++++++++++------
 drivers/net/ethernet/sfc/siena_sriov.c             |    3 +-
 include/linux/if_link.h                            |    3 +-
 include/linux/netdevice.h                          |    8 ++-
 include/uapi/linux/if_link.h                       |    9 +++-
 net/core/rtnetlink.c                               |   38 ++++++++++++--
 20 files changed, 142 insertions(+), 60 deletions(-)

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists