netdev - Re: [PATCH v1] net: phy: resume phydev when going to RESUMING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400032650.24350.79.camel@joe-AO725>
Date:	Tue, 13 May 2014 18:57:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Zhangfei Gao <zhangfei.gao@...aro.org>
Cc:	sebastian.hesselbarth@...il.com, f.fainelli@...il.com,
	davem@...emloft.net, sergei.shtylyov@...entembedded.com,
	netdev@...r.kernel.org, Jiancheng Xue <xuejiancheng@...wei.com>
Subject: Re: [PATCH v1] net: phy: resume phydev when going to RESUMING

On Wed, 2014-05-14 at 09:40 +0800, Zhangfei Gao wrote:
> With commit be9dad1f9f26604fb ("net: phy: suspend phydev when going
> to HALTED"), an unused PHY device will be put in a low-power mode
> using BMCR_PDOWN. Some Ethernet drivers might be calling phy_start()
> and phy_stop() from ndo_open and ndo_close() respectively, while
> calling phy_connect() and phy_disconnect() from probe and remove.
> In such a case, the PHY will be powered down during the phy_stop()
> call, but will fail to be powered up in phy_start().
> This patch fixes this scenario.

trivial notes:

> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
[]
> @@ -715,7 +715,7 @@ void phy_state_machine(struct work_struct *work)
>  	struct delayed_work *dwork = to_delayed_work(work);
>  	struct phy_device *phydev =
>  			container_of(dwork, struct phy_device, state_queue);
> -	int needs_aneg = 0, do_suspend = 0;
> +	int needs_aneg = 0, do_suspend = 0, do_resume = 0;

Perhaps these 3 vars should bool

> @@ -876,6 +878,9 @@ void phy_state_machine(struct work_struct *work)
>  	if (do_suspend)
>  		phy_suspend(phydev);
>  
> +	if (do_resume)
> +		phy_resume(phydev);
> +

and these should be else if

	if (needs_aneg)
		...
	else if (do_suspend)
		...
	else if (do_resume)
		...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html