netdev - Re: [PATCH v2 net-next 3/9] bonding: make BOND_NO_USES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140515154527.GA2789@mikrodark.usersys.redhat.com>
Date:	Thu, 15 May 2014 17:45:27 +0200
From:	Veaceslav Falico <vfalico@...il.com>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH v2 net-next 3/9] bonding: make BOND_NO_USES_ARP an inline
 function

On Thu, May 15, 2014 at 08:35:47AM -0700, Alexei Starovoitov wrote:
>On Thu, May 15, 2014 at 5:29 AM, Veaceslav Falico <vfalico@...il.com> wrote:
...snip...
>> -       if (BOND_NO_USES_ARP(bond_mode)) {
>> +       if (!bond_mode_uses_arp(bond_mode)) {
>
>looks like condition becomes inverted.
>Did you mean to add '!' inside bond_mode_uses_arp() as well?

Right, good catch. Easy to miss with this amount of mechanical work :(.

I'll wait for more feedback and resubmit v3.

Thanks!

>
...snip...
>> -#define BOND_NO_USES_ARP(mode)                         \
>> -               (((mode) == BOND_MODE_8023AD)   ||      \
>> -                ((mode) == BOND_MODE_TLB)      ||      \
>> -                ((mode) == BOND_MODE_ALB))
>> -
...snip...
>> +static inline bool bond_mode_uses_arp(int mode)
>> +{
>> +       return mode == BOND_MODE_8023AD || mode == BOND_MODE_TLB ||
>> +              mode == BOND_MODE_ALB;
>> +}
>> +
...snip...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html