netdev - Re: [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5374E57E.8010708@redhat.com>
Date:	Thu, 15 May 2014 12:04:14 -0400
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	shemminger@...tta.com, mst@...hat.com, john.r.fastabend@...el.com,
	jhs@...atatu.com
Subject: Re: [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic
 discovery.

On 05/14/2014 11:42 AM, Stephen Hemminger wrote:
> On Wed, 14 May 2014 11:09:22 -0400
> Vlad Yasevich <vyasevic@...hat.com> wrote:
> 
>> @@ -58,6 +61,7 @@ static int store_flag(struct net_bridge_port *p, unsigned long v,
>>  
>>  	if (flags != p->flags) {
>>  		p->flags = flags;
>> +		br_port_flags_change(p, old_flags ^ flags);
> 
> You are also xoring twice.
> 

That's wrong...  I've take care of that.

> Why not:
> 
> store_flag()
> 	if (flags != p->flags) {
> 		br_port_flags_change(p, flags);
> 		p->flags = flags;
> 		br_ifinfo_notify(RTM_NEWLINK, p);
> 

This doesn't really make sense as flags_change handler will use current
flag value and that would be wrong.  We'd have to pass the new flags
along, but that doesn't make sense either.

I'll send the update shortly.

Thanks
-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html