netdev - Re: [PATCH RFC net-next] tracing: accelerate tracing filters with BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMEtUux=StoEADDrJSqQ4p_GMDDq+MjVjHnQsBaLRST5xRLbKA@mail.gmail.com>
Date:	Wed, 14 May 2014 22:19:37 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Daniel Borkmann <dborkman@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Network Development <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC net-next] tracing: accelerate tracing filters with BPF

On Tue, May 13, 2014 at 10:09 PM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Alexei Starovoitov <ast@...mgrid.com> wrote:
>
>> On Tue, May 13, 2014 at 8:17 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>> > On Tue, 13 May 2014 19:55:11 -0700
>> > Alexei Starovoitov <ast@...mgrid.com> wrote:
>> >
>> >> Tracing filters are parsing user supplied character string and constructing
>> >> a predicate tree. filter_match_preds() was used to walk nodes of the tree to
>> >> simulate matching of boolean expression.
>> >>
>> >
>> > I applied this on top of net-next, from:
>> >
>> >  git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
>> >  (master branch)
>> >
>> > and got this compile error:
>>
>> Sorry I wasn't clear in the log.
>> This patch depends on JIT patches that were posted separately.
>> Since this one is RFC, I didn't want to mix them.
>> JIT patches:
>> http://patchwork.ozlabs.org/patch/348558/
>> http://patchwork.ozlabs.org/patch/348559/
>> http://patchwork.ozlabs.org/patch/348560/
>
> Might make sense for you to get a korg account and stick such bits
> into Git trees, to ease testing.

it would be an honor. Thank you.

What is the next step for this particular patch?
Sounds like dependency on full net is a showstopper.
I think splitting bpf into small component will clean up
dependency for seccomp as well.
bpf can move into net/bpf/ dir and go via net-next tree.
If Dave is ok with this, I can start hacking.
It looks to be more or less straight forward.
There are few ways to split it. The only contentious piece
is skb_copy_bits(). I think we can come up with something.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html