netdev - Re: [PATCH net v2] rtnetlink: wait for unregistering devices in rtnl_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVu+X7tM43QD23BpE9bNemVFcPznOmTFQb_pQ2gA=c9Qg@mail.gmail.com>
Date:	Thu, 15 May 2014 11:43:26 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Cong Wang <cwang@...pensource.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH net v2] rtnetlink: wait for unregistering devices in rtnl_link_unregister()

On Thu, May 15, 2014 at 11:32 AM, David Miller <davem@...emloft.net> wrote:
> From: Cong Wang <xiyou.wangcong@...il.com>
> Date: Mon, 12 May 2014 15:11:20 -0700
>
>> +static void rtnl_lock_unregistering_all(void)
>
> This is just:
>
>         rtnl_lock_unregistering(&net_namespace_list);
>
> There is no need to reimplement the entire thing.

This is exactly what I did in v0 (never sent out) locally,
I spent few hours to debug the problem. The problem
is net_namespace_list links netns by net->list,
while rtnl_lock_unregistering() uses net->exit_list.
Thus I used an ugly macro in v1.

There seems no other choice than  between
an ugly macro and duplicated code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html