lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 May 2014 14:03:34 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Jay Vosburgh <jay.vosburgh@...onical.com> Cc: netdev@...r.kernel.org, netem@...ts.linux-foundation.org Subject: Re: [PATCH iproute2] tc/netem: loss gemodel options fixes On Sat, 10 May 2014 13:34:58 -0700 Jay Vosburgh <jay.vosburgh@...onical.com> wrote: > > First, the default value for 1-k is documented as being 0, but is > currently being set to 1. (100%). This causes all packets to be dropped > in the good state if 1-k is not explicitly specified. Fix this by setting > the default to 0. > > Second, the 1-h option is parsed correctly, however, the kernel is > expecting "h", not 1-h. Fix this by inverting the "1-h" percentage before > sending to and after receiving from the kernel. This does change the > behavior, but makes it consistent with the netem documentation and the > literature on the Gilbert-Elliot model, which refer to "1-h" and "1-k," > not "h" or "k" directly. > > Last, fix a minor formatting issue for the options reporting. > > Signed-off-by: Jay Vosburgh <jay.vosburgh@...onical.com> Could you get review of original author of this loss model? Stefano Salsano <stefano.salsano@...roma2.it> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists