netdev - Re: [PATCH] Fix for possible null pointer dereference in auth.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAABAsM69JO2F95+uVzbSzOSbnNz2ae0kdffy8m-pGDRr_QR=+g@mail.gmail.com>
Date:	Thu, 15 May 2014 18:07:01 -0400
From:	Trond Myklebust <trond.myklebust@...marydata.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	"J. Bruce Fields" <bfields@...ldses.org>,
	"David S. Miller" <davem@...emloft.net>, linux-nfs@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix for possible null pointer dereference in auth.c

On Thu, May 15, 2014 at 5:56 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  net/sunrpc/auth.c |   10 +++++++---
>  1 fil ändrad, 7 tillägg(+), 3 borttagningar(-)
>
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index 5285ead..3a55698 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -801,10 +801,14 @@ rpcauth_invalcred(struct rpc_task *task)
>  {
>         struct rpc_cred *cred = task->tk_rqstp->rq_cred;
>
> -       dprintk("RPC: %5u invalidating %s cred %p\n",
> -               task->tk_pid, cred->cr_auth->au_ops->au_name, cred);
> -       if (cred)
> +       if (cred) {
> +               dprintk("RPC: %5u invalidating %s cred %p\n",
> +                       task->tk_pid, cred->cr_auth->au_ops->au_name, cred);
> +
>                 clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags);
> +       }
> +       else
> +               dprintk("RPC: %5u invalidating is NULL\n", task->tk_pid);
>  }
>
>

Can you please explain how we can get to rpcauth_invalcred() without a
valid cred pointer? I'm not seeing it...

Cheers
  Trond
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html