netdev - Re: [PATCH net] ip_tunnel: Initialize the fallback device properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400160127.7973.133.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 15 May 2014 06:22:07 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] ip_tunnel: Initialize the fallback device properly

On Thu, 2014-05-15 at 09:43 +0200, Steffen Klassert wrote:
> We need to initialize the fallback device to have a correct mtu
> set on this device. Otherwise the mtu is set to null and the device
> is unusable.
> 
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> ---
>  net/ipv4/ip_tunnel.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
> index b3f8597..25b8997 100644
> --- a/net/ipv4/ip_tunnel.c
> +++ b/net/ipv4/ip_tunnel.c
> @@ -882,6 +882,7 @@ int ip_tunnel_init_net(struct net *net, int ip_tnl_net_id,
>  	 */
>  	if (!IS_ERR(itn->fb_tunnel_dev)) {
>  		itn->fb_tunnel_dev->features |= NETIF_F_NETNS_LOCAL;
> +		itn->fb_tunnel_dev->mtu = ip_tunnel_bind_dev(itn->fb_tunnel_dev);
>  		ip_tunnel_add(itn, netdev_priv(itn->fb_tunnel_dev));
>  	}
>  	rtnl_unlock();

Hi Steffen.

It would be nice if you also added the reference of the commit
adding the bug ;)

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html