netdev - Re: [bisected] [oops] gre/gro oops in skb_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 May 2014 09:29:29 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Timo Teras <timo.teras@....fi>
Cc:	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [bisected] [oops] gre/gro oops in skb_gro_receive+0x118/0x453

On Fri, 2014-05-16 at 17:34 +0300, Timo Teras wrote:

> Ah, did not notice that one. So I'm adding Herbert as explicit cc.
> 
> $ git describe --contains 9d8506cc2d7ea1f911c72c100193a3677f6668c3
> v3.13-rc1~7^2
> 
> But as you may have noticed, the attached oops is from 3.14.4 that
> includes the fix commit. While bisecting, I tested multiple versions
> between 3.12 and 3.14. Bisecting clearly points this is the commit that
> introduces this oops, and it is not fixed in any version up until
> 3.14.4.
> 
> Also the forward path from gre->ethX goes to eth that does not have
> TSO/GSO support. So I'd assume that the fix commit is not that
> relevant in my specific test case.
> 
> The faulty commit must be introducing additional bug, and the commit
> you refer did not fix it.

Right. The commit could expose a dormant bug in a driver.

For example, some drivers might forget to use skb_put()

Please give us more details.

What is the driver receiving ethernet frames ?

Is it using GRO ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html