netdev - Re: [PATCH] net: gro: make sure skb->cb[] initial content has not to be zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140516220822.5d749752@vostro>
Date:	Fri, 16 May 2014 22:08:22 +0300
From:	Timo Teras <timo.teras@....fi>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] net: gro: make sure skb->cb[] initial content has not
 to be zero

On Fri, 16 May 2014 11:34:37 -0700
Eric Dumazet <eric.dumazet@...il.com> wrote:

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Starting from linux-3.13, GRO attempts to build full size skbs.
> 
> Problem is the commit assumed one particular field in skb->cb[]
> was clean, but it is not the case on some stacked devices.
> 
> Timo reported a crash in case traffic is decrypted before
> reaching a GRE device.
> 
> Fix this by initializing NAPI_GRO_CB(skb)->last at the right place,
> this also removes one conditional.
> 
> Thanks a lot to Timo for providing full reports and bisecting this.
> 
> Fixes: 8a29111c7ca6 ("net: gro: allow to build full sized skb")
> Bisected-by: Timo Teras <timo.teras@....fi>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> Please Timo test this patch so that we confirm it fixes the bug for
> you.

Yes, everything looks green now! (The test case reproduced the crash
reliably and immediately. Now it's been up and working for more than
tens minutes already :)

Tested-by: Timo Teräs <timo.teras@....fi>

Needless to say, this should go to 3.14-stable as well.

Thanks a lot Eric!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html