netdev - Re: [PATCH v2] net: phy: resume phydev when going to RESUMING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140516.151840.1337260559187267551.davem@davemloft.net>
Date:	Fri, 16 May 2014 15:18:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	zhangfei.gao@...aro.org
Cc:	sebastian.hesselbarth@...il.com, f.fainelli@...il.com,
	sergei.shtylyov@...entembedded.com, joe@...ches.com,
	netdev@...r.kernel.org, xuejiancheng@...wei.com
Subject: Re: [PATCH v2] net: phy: resume phydev when going to RESUMING

From: Zhangfei Gao <zhangfei.gao@...aro.org>
Date: Thu, 15 May 2014 13:35:34 +0800

> With commit be9dad1f9f26604fb ("net: phy: suspend phydev when going
> to HALTED"), an unused PHY device will be put in a low-power mode
> using BMCR_PDOWN. Some Ethernet drivers might be calling phy_start()
> and phy_stop() from ndo_open and ndo_close() respectively, while
> calling phy_connect() and phy_disconnect() from probe and remove.
> In such a case, the PHY will be powered down during the phy_stop()
> call, but will fail to be powered up in phy_start().
> This patch fixes this scenario.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@...wei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@...aro.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html