netdev - Re: [RFC PATCH] net: Add support for device specific address syncing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140516.164728.2297526772904518777.davem@davemloft.net>
Date:	Fri, 16 May 2014 16:47:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	jpirko@...hat.com
Subject: Re: [RFC PATCH] net: Add support for device specific address
 syncing

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Fri, 16 May 2014 12:55:42 -0700

> I can understand going into promisc on a sync failure, but why would you
> do it on an unsync failure, or are you saying that we would be clearing
> the flag in unsync?

We should clear the promisc flag on unsync if the limitations are no
longer exceeded.

> In general I intended for this to be called in set_rx_mode so if
> __dev_uc_sync returns an error indicating insufficient resources we have
> to force IFF_PROMISC on because adding a new address failed.  We could
> also do the same thing for __dev_mc_sync and IFF_ALLMULTI.

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html